Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JRuby stringio does not define StringIO::VERSION #57

Closed
headius opened this issue Aug 9, 2023 · 0 comments · Fixed by #59
Closed

JRuby stringio does not define StringIO::VERSION #57

headius opened this issue Aug 9, 2023 · 0 comments · Fixed by #59

Comments

@headius
Copy link
Contributor

headius commented Aug 9, 2023

This led to failures when specs were updated recently in JRuby by @eregon:

https://github.com/jruby/jruby/actions/runs/5796844530/job/15711235891#step:6:657

Because this error occurs outside the execution of specs, it cannot be tagged or omitted.

I have a pull request coming that will add a stringio/version.rb that would be shared between JRuby and other impls, rather than the C-based constant currently being used.
headius added a commit to headius/jruby that referenced this issue Aug 9, 2023
@headius
Omit StringIO#each specs that check VERSION
b6e3b37 
The JRuby version of StringIO does not define VERSION, but since
this version check happens within the setup for the specs it
cannot be tagged easily.

This commit omits the StringIO specs from our CI runs altogether
until we can address the missing constant.

See ruby/stringio#57
@headius headius mentioned this issue Aug 9, 2023
Merged
headius added a commit to headius/stringio that referenced this issue Aug 9, 2023
@headius
Add version.rb and load it from stringio.rb
0229d78 
Fixes ruby#57
@headius headius mentioned this issue Aug 9, 2023
Closed
headius added a commit to headius/jruby that referenced this issue Aug 9, 2023
@headius
Omit StringIO#each specs that check VERSION
88d2657 
The JRuby version of StringIO does not define VERSION, but since
this version check happens within the setup for the specs it
cannot be tagged easily.

This commit omits the StringIO specs from our CI runs altogether
until we can address the missing constant.

See ruby/stringio#57
headius added a commit to headius/jruby that referenced this issue Aug 9, 2023
@headius
Omit StringIO specs temporarily
e3b9932 
Several StringIO specs now check for StringIO::VERSION in order
to spec the correct behavior for the version of StringIO present.
The JRuby version of StringIO does not define VERSION, but since
this version check happens within the setup for the specs it
cannot be tagged off easily.

This commit omits the StringIO specs from our CI runs altogether
until we can address the missing constant.

See ruby/stringio#57
kou added a commit that referenced this issue Aug 10, 2023
@kou
jruby: Add StringIO::VERSION
c4e0800 
Fixes GH-57
@kou kou mentioned this issue Aug 10, 2023
Merged
@kou kou closed this as completed in #59 Aug 10, 2023
kou added a commit that referenced this issue Aug 10, 2023
@kou
jruby: Add StringIO::VERSION (#59)
583d901 
Fixes GH-57
headius added a commit to headius/jruby that referenced this issue Aug 10, 2023
@headius
Update to stringio 3.0.8
86e3b82 
* Adds StringIO::VERSION to the JRuby library (ruby/stringio#57)
* Tags two specs for getline para behavior new after 3.0.6 (ruby/stringio#61)
headius added a commit to headius/jruby that referenced this issue Aug 10, 2023
@headius
Update to stringio 3.0.8
7b1f194 
* Adds StringIO::VERSION to the JRuby library (ruby/stringio#57)
* Tags two specs for getline para behavior new after 3.0.6 (ruby/stringio#61)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
1 participant
@headius