Update registers after parsing integers #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JRuby needs the same fix it seems. |
byroot
force-pushed
the
fix-scan-integer
branch
from
bfa886e to
095895e
Compare
Done. |
eregon
reviewed
Feb 12, 2025
byroot
force-pushed
the
fix-scan-integer
branch
from
095895e to
404ee23
Compare
kou
reviewed
Feb 13, 2025
kou
reviewed
Feb 13, 2025
test/strscan/test_stringscanner.rb
Outdated
| assert_equal("42", s.matched) | ||
|
|
||
| s = create_string_scanner("42abc") | ||
| assert_equal(273084, s.scan_integer(base: 16)) |
There was a problem hiding this comment.
How about using hex literal for easy to read?
Suggested change
| assert_equal(273084, s.scan_integer(base: 16)) | |
| assert_equal(0x42abc, s.scan_integer(base: 16)) |
byroot
force-pushed
the
fix-scan-integer
branch
from
688fd80 to
2a3510c
Compare
|
Thanks for the review. Updated. |
|
Thanks! |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Feb 14, 2025
data (ruby/strscan#133) Fix ruby/strscan#130 Reported by Andrii Konchyn. Thanks!!! ruby/strscan@4e5f17f87a
mrzasa
pushed a commit
to mrzasa/ruby
that referenced
this pull request
Feb 21, 2025
data (ruby/strscan#133) Fix ruby/strscan#130 Reported by Andrii Konchyn. Thanks!!! ruby/strscan@4e5f17f87a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix GH-130