Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URI::Generic#decoded_#{user,password} #17

Merged
merged 1 commit into from
May 12, 2022

Commits on Mar 4, 2021

  1. Add URI::Generic#decoded_#{user,password}

    URI::Generic#{user,password} return the encoded values, which are
    not that useful if you want to do authentication with them.
    Automatic decoding by default would break backwards compatibility.
    Optional automatic decoding via a keyword to URI.parse would
    require threading the option through at least 3 other methods, and
    would make semantics confusing (user= takes encoded or unencoded
    password?) or require more work.  Thus, adding this as a separate
    method seemed the simplest approach.
    
    Unfortunately, URI lacks a method for correct decoding.  Unlike in
    www form components, + in earlier parts of the URI such as the
    userinfo section is treated verbatim and not as an encoded space.
    Add URI.#{en,de}code_uri_component methods, which are almost the
    same as URI.#{en,de}code_www_form_component, but without the
    special SP => + handling.
    
    Implements [Feature #9045]
    jeremyevans committed Mar 4, 2021
    Configuration menu
    Copy the full SHA
    f496dee View commit details
    Browse the repository at this point in the history