URI#HTTP#origin and URI#HTTP#authority #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
approved these changes
Sep 20, 2021
|
@HoneyryderChuck I made some cosmetic changes. Hope that's okay with you, and I'm going to merge it. |
|
@ioquatix that's fine, only got time for this now, thx for jumping in :) |
|
Also, just to be clear: what's the release policy for this change? Will this be synched to be released only with ruby 3.1? How will that affect the RBS signatures for the |
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Oct 22, 2021
ruby/uri@bf13946c32 Co-authored-by: Samuel Williams <samuel.williams@oriontransfer.co.nz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at porting to mainline an abstraction that I've been using successfuly (as a refinement) over +3y. (ref: https://gitlab.com/honeyryderchuck/httpx/-/blob/master/lib/httpx/extensions.rb#L124-131).
authorityandoriginare concepts which I see reinvented (and reimplemented) in a lot of ruby HTTP infrastructure (rack, app servers likepuma,net-httpitself). It's usefulness is so fundamental on so many levels (connection pools by origin, check byHostheader, some rack spec fields) thaturicould abstract it away.