Pass tests on CI for macOS #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ono-max
force-pushed
the
patch-16
branch
2 times, most recently
from
68766ce to
032bb3d
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VS code overrides The PATH environment variable:
https://github.com/microsoft/vscode/blob/1.73.0/src/vs/server/node/extensionHostConnection.ts#L59
Thus, when we execute ruby command like
ruby target.rb, therubypath may be wrong as followsThe PATH environment variable before running VS Code:
/Users/runner/work/vscode-rdbg/vscode-rdbg/node_modules/.bin:/Users/runner/work/vscode-rdbg/node_modules/ ... /bin:/Users/runner/hostedtoolcache/Ruby/3.1.2/ ...
The PATH environment variable after running VS Code:
/usr/local/lib/ruby/gems/3.0.0/bin:/usr/local/opt/ruby@3.0/ ... /Users/runner/work/vscode-rdbg/vscode-rdbg/node_modules/.bin:/Users/runner/work/vscode-rdbg/node_modules/
To solve this problem, I set The RUBY_DEBUG_TEST_PATH environment variable for getting correct ruby path when testing.