Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions instead of Travis CI (retry) #40

Merged
merged 1 commit into from
May 31, 2020

Conversation

deivid-rodriguez
Copy link

Code from #38 adapted to verify how webrick is doing on jruby.

(Got here from rubygems/rubygems#3451).

@deivid-rodriguez deivid-rodriguez marked this pull request as draft April 10, 2020 19:07
@deivid-rodriguez
Copy link
Author

Marking this as a draft since I'm just experimenting with jruby.

@headius
Copy link
Contributor

headius commented May 12, 2020

Any luck on getting this further along?

@deivid-rodriguez
Copy link
Author

No :(

My intention was not to try to fix webrick tests against jruby, only to verify that they were failing.

@deivid-rodriguez
Copy link
Author

deivid-rodriguez commented May 12, 2020

@hsbt Should I get these changes ready (excluding jruby), so that we can migrate to Github Actions?

@headius
Copy link
Contributor

headius commented May 28, 2020

I have filed jruby/jruby#6248 which discusses the test_cgi failure. In short it won't be possible to support arbitrary bytes passed via environment variables (as is the case in the quoted test_cgi example) without JRuby bypassing the JDK's own environment variable support.

I believe the test in question should have its exclusion expanded to the "java" platform for now, since there's no timeline for us to reimplement environment variable support in JRuby.

unless RUBY_PLATFORM =~ /mswin|mingw|cygwin|bccwin32/

Note also jruby/jruby#6246 which should fix the remaining failures (I'm down to about 4 or 5).

@deivid-rodriguez deivid-rodriguez force-pushed the github_actions branch 2 times, most recently from 4f4e731 to e6f9e10 Compare May 31, 2020 15:12
@deivid-rodriguez deivid-rodriguez marked this pull request as ready for review May 31, 2020 16:06
@deivid-rodriguez
Copy link
Author

@hsbt I updated this PR to limit it to only migrating the current TravisCI configuration to Github Actions. Let me know!

@hsbt
Copy link
Member

hsbt commented May 31, 2020

Seems fine. Thanks!

@hsbt hsbt merged commit 637d215 into ruby:master May 31, 2020
@deivid-rodriguez deivid-rodriguez deleted the github_actions branch June 1, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants