Extract creation of Net::HTTP in httpproxy

[wishdev]

The "evil-proxy" gem [1] allows one to create an HTTPS man-in-the-middle proxy using webrick/httpproxy as the base.

It's a fairly unmaintained gem and therefore has fallen behind not-so-recent changes within webrick.

The biggest issue with e-p is its use of perform_proxy_request from webrick/httpproxy. Since httpproxy does not handle HTTPS requests in normal use the Net::HTTP object does not respect the fact that it might be used for that. Therefore evil-proxy basically has a cut/paste version of perform_proxy_request within it. So that means any changes to webrick require another cut-and-paste update to e-p.

I'd like to use e-p but I'd rather not cut-and-paste the method back in. Therefore I'm wondering if the following small patch would be acceptable. It simply moves the Net::HTTP.new call out into a distinct method which allows e-p to simply override that method to allow for use_ssl and verify_mode to be customized.

Thanks!

[1] - https://github.com/bbtfr/evil-proxy

[jeremyevans]

Thanks for the patch! This looks fine and shouldn't have any backwards compatibility issues.