Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Works on Arm logo on our English website. #3183

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

junaruga
Copy link
Member

@junaruga junaruga commented Jan 17, 2024

This PR is to add Arm's logo sponsoring us for a Ubuntu Arm neoverse server (RubyCI - "Ubuntu arm neoverse") as their project Works on Arm to our English website: https://www.ruby-lang.org/en/about/website/ as our appreciation.

I got the logo image from "Arm Blue Logo" on this page. The url is https://www.arm.com/-/media/global/logos/Arm-logo-blue-pms313.svg . The image file is originally .svg file. I converted it to png file (image size 237 x 72 pixels).

You can check the updated document here on my forked repository.

I am going to confirm our folks at Arm before merging this PR.

@hsbt hsbt self-assigned this Jan 18, 2024
@junaruga
Copy link
Member Author

I would ask you for the PR's review after I can contact with people at Arm.

Copy link
Member

@sorah sorah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good so approving, but acknowledge to hold merging until Arm team's confirmation

@junaruga
Copy link
Member Author

A person at Arm told me that they would prefer to use Works on Arm's logo rather than Arm's logo. And I am asking them to get the Works on Arm's logo image file now.

@junaruga junaruga changed the title Adding Arm logo on our English website. Adding Works on Arm logo on our English website. Feb 1, 2024
@junaruga
Copy link
Member Author

junaruga commented Feb 1, 2024

A person at Arm told me that they would prefer to use Works on Arm's logo rather than Arm's logo. And I am asking them to get the Works on Arm's logo image file now.

I received a Works on Arm logo image file (png file) from a person at Arm. The file was the width x height = 7808px x 650px (file size: 751.3 KB) with a transparent background color. As the image size was bigger than other images under the images/sponsor/*.png files, I scaled the image size down by myself into the 300px x 26px (file size: 9.5 KB).

The reason why I decided the width 300px is because the image file with longest width is mackerel.png whose width is 300px. Though the mackerel.png has padding spaces unilke the works-on-arm.png, the appearance is a bit different.

You can check the updated document here on my forked repository again.

I rebased this PR updating the commit message too on the latest master branch.

@junaruga junaruga marked this pull request as ready for review February 1, 2024 15:15
@junaruga junaruga requested a review from a team as a code owner February 1, 2024 15:15
@junaruga
Copy link
Member Author

junaruga commented Feb 1, 2024

Could you review again? Thank you.

@hsbt
Copy link
Member

hsbt commented Feb 2, 2024

@junaruga Thank you ❤️

@hsbt hsbt merged commit 41f34c2 into ruby:master Feb 2, 2024
1 check passed
@junaruga junaruga deleted the wip/website-sponsor-arm branch February 2, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants