Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation page #3355

Merged
merged 2 commits into from
Sep 2, 2024

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Aug 27, 2024

  1. Remove dead or outdated links
  2. Make the link to VS Code directly visit its Ruby doc

- Link 13 and 15 both point to https://ruby-doc.org/3.2.2, which is not
  up to date and don't provide more information than the official docs.
- Link 17 points to https://rubydocs.org/ which is not maintained anymore.
- Link 18 points to https://apidock.com/ only has information up to Ruby
  2.6, which is clearly outdated.
Copy link
Member

@JuanitoFatas JuanitoFatas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@JuanitoFatas JuanitoFatas merged commit 5d9fba6 into ruby:master Sep 2, 2024
1 check passed
Comment on lines -138 to -140
[13]: http://www.ruby-doc.org/core
[14]: https://ruby.github.io/rdoc/
[15]: http://www.ruby-doc.org/stdlib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both [13] and [15] redirects to https://ruby-doc.org/3.3.4/ now, so I think we don't have to remove these?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[34] also links to http://ruby-doc.org, it needs to be https though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants