Support time inputs

[Antsiscool]

I am converting a project over from capybara selenium and found that time inputs were failing to be correctly set.

This allows specifying the time as a string or a Time object. The date attributes will be ignored.

I have added test cases for both string and time. I also added some test cases for date inputs as well.

[Antsiscool]

I am not sure why the tests are failing. They are all failing for me locally on the main branch as well.

[brodienguyen]

I am interested in following up this contribution as well.

@route Not sure if you are the project's maintainer, but could you give us some insights if you know why all the tests are falling please?

[Antsiscool]

I have just rebased my changes onto the latest main branch.

[route]

Just approved them to run

[route]

Weird, dunno let me release new Ferrum and push my changes to cuprite and I'll get this into new release

[Slotos]

I suggest changing lib/capybara/cuprite/javascripts/index.js to:

    } else if (node.type == "time") {
      this.setValue(node, value);
      this.input(node);

Suggested change

	when "time"
	value = value.strftime("%H:%M") if value.is_a?(Time)
	node.evaluate("this.setAttribute('value', '#{value}')")
	when "time"
	value = value.strftime("%H:%M") if value.is_a?(Time)
	command(:set, value.to_s)

This way, input event will be emitted correctly and value attribute won't be modified unnecessarily.

[janwerkhoven]

Need this. +1 👀