Support Driver#send_keys and :focused filter
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
focused-filter
branch
2 times, most recently
from
af5a7a3 to
405517d
Compare
seanpdoyle
commented
Feb 29, 2024
seanpdoyle
force-pushed
the
focused-filter
branch
3 times, most recently
from
533fd70 to
03c3d08
Compare
seanpdoyle
changed the title
Node#active_element and :focused filterNode#send_keys and :focused filter
seanpdoyle
changed the title
Node#send_keys and :focused filterDriver#send_keys and :focused filter
As of [teamcapybara/capybara#2489][] (April 14, 2021), Capybara supports calling `#send_keys` on the page (instead of a particular element). Similarly, there is a global `:focused` filter that compares the node to the [Document.activeElement][]. These are both powered by a [Driver#active_element][] method in drivers that support JavaScript. This commit integrates `Capybara::Cuprite::Driver` to support both. [teamcapybara/capybara#2489]: teamcapybara/capybara#2489 [Driver#active_element]: https://github.com/teamcapybara/capybara/blob/c0cbf4024c1abd48b0c22c2930e7b05af58ab284/lib/capybara/driver/base.rb#L62-L68 [Document.activeElement]: https://developer.mozilla.org/en-US/docs/Web/API/Document/activeElement
seanpdoyle
force-pushed
the
focused-filter
branch
from
03c3d08 to
6b12556
Compare
|
@route could you please approve CI to execute? |
|
Awesome, thanks Sean! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of teamcapybara/capybara#2489 (April 14, 2021), Capybara supports calling
#send_keyson the page (instead of a particular element).Similarly, there is a global
:focusedfilter that compares the node to the Document.activeElement.These are both powered by a Driver#active_element method in drivers that support JavaScript.
This commit integrates
Capybara::Cuprite::Driverto support both.