Merge branch 'api' of github.com:xihai01/casa into api

.allow_skipping_tests

@@ -1,59 +1,21 @@
 channels/application_cable/channel.rb
 channels/application_cable/connection.rb
-controllers/all_casa_admins/casa_admins_controller.rb
-controllers/all_casa_admins/dashboard_controller.rb
-controllers/all_casa_admins/patch_notes_controller.rb
-controllers/all_casa_admins/sessions_controller.rb
-controllers/all_casa_admins_controller.rb
-controllers/android_app_associations_controller.rb
-controllers/application_controller.rb
-controllers/casa_admins_controller.rb
-controllers/casa_org_controller.rb
-controllers/case_assignments_controller.rb
-controllers/case_contact_reports_controller.rb
-controllers/case_contacts/followups_controller.rb
-controllers/case_contacts_controller.rb
-controllers/case_court_orders_controller.rb
-controllers/case_court_reports_controller.rb
-controllers/checklist_items_controller.rb
-controllers/contact_type_groups_controller.rb
-controllers/contact_types_controller.rb
-controllers/court_dates_controller.rb
-controllers/dashboard_controller.rb
-controllers/emancipation_checklists_controller.rb
-controllers/error_controller.rb
+controllers/banners_controller.rb
+controllers/bulk_court_dates_controller.rb
+controllers/case_groups_controller.rb
+controllers/concerns/court_date_params.rb
 controllers/followup_reports_controller.rb
-controllers/fund_requests_controller.rb
-controllers/health_controller.rb
-controllers/hearing_types_controller.rb
-controllers/imports_controller.rb
-controllers/judges_controller.rb
-controllers/languages_controller.rb
-controllers/learning_hours_controller.rb
-controllers/learning_hours_reports_controller.rb
-controllers/mileage_rates_controller.rb
+controllers/learning_hour_types_controller.rb
 controllers/mileage_reports_controller.rb
-controllers/missing_data_reports_controller.rb
-controllers/notes_controller.rb
-controllers/notifications_controller.rb
-controllers/other_duties_controller.rb
 controllers/placements_controller.rb
-controllers/placement_reports_controller.rb
-controllers/reports_controller.rb
-controllers/supervisor_volunteers_controller.rb
-controllers/supervisors_controller.rb
-controllers/users/passwords_controller.rb
 controllers/users/sessions_controller.rb
-controllers/users_controller.rb
-controllers/volunteers_controller.rb
 datatables/application_datatable.rb
 decorators/application_decorator.rb
 decorators/case_assignment_decorator.rb
 decorators/court_date_decorator.rb
 decorators/learning_hour_decorator.rb
 helpers/all_casa_admins/casa_orgs_helper.rb
 helpers/api_base_helper.rb
-helpers/contact_types_helper.rb
 helpers/date_helper.rb
 helpers/request_header_helper.rb
 helpers/template_helper.rb
@@ -71,9 +33,9 @@ notifications/emancipation_checklist_reminder_notification.rb
 notifications/followup_notification.rb
 notifications/followup_resolved_notification.rb
 notifications/youth_birthday_notification.rb
-policies/case_court_order_policy.rb
 policies/fund_request_policy.rb
 policies/learning_hour_policy.rb
+policies/learning_hour_type_policy.rb
 policies/note_policy.rb
 presenters/base_presenter.rb
 presenters/case_contact_presenter.rb
@@ -82,7 +44,6 @@ services/court_report_format_contact_date.rb
 services/create_all_casa_admin_service.rb
 services/create_casa_admin_service.rb
 services/fdf_inputs_service.rb
-services/mileage_export_csv_service.rb
 validators/casa_org_validator.rb
 validators/court_report_validator.rb
 validators/user_validator.rb

.github/ISSUE_TEMPLATE/bug_report.md

@@ -5,29 +5,30 @@ title: "Bug: "
 labels: ["Type: Bug", "Help Wanted"]
 ---
 
-### Impacted User Types
+## Impacted User Types
  - volunteers?
  - supervisors?
  - admins?
  - all casa admins?
 
-### Environment
+## Environment
 ex: staging, desktop web, Safari
 
-### Current Behavior
+## Current Behavior
 ex: When I click "generate report," no report is generated.
 _Please include a screenshot!_
 
-### Expected Behavior
+## Expected Behavior
 ex: When I click "generate report", a downloadable report should be generated.
 
-### How to Replicate
+## How to Replicate
 ex: 
 1. - Log in as an admin or supervisor.
 2. - Click on "Generate Reports" in the left sidebar menu.
 3. - Filter by a volunteer who has logged at least one case contact.
 4. - Click "Generate report" at the bottom of the page.
 
+## How to access the QA site
 _Login Details:_  
 [Link to QA site](https://casa-qa.herokuapp.com/)  
 

.github/ISSUE_TEMPLATE/feature_request.md

@@ -4,18 +4,19 @@ about: 🔨What needs building? ✨
 labels: ["✨ New Feature", "Help Wanted"]
 ---
 
-**What type(s) of user does this feature affect?**
+## What type(s) of user does this feature affect?
  - volunteers?
  - supervisors?
  - admins?
  - all casa admins?
 
-**Description**
+## Description
 
 
-**Screenshots of current behavior, if any**  
+## Screenshots of current behavior, if any
 You can paste images on the clipboard here
 
+## How to access the QA site
 _Login Details:_  
 [Link to QA site](https://casa-qa.herokuapp.com/)  
 

.github/ISSUE_TEMPLATE/flaky_test.md

@@ -7,19 +7,13 @@ labels: ["Type: Bug", "Help Wanted"]
 Flaky tests are defined as tests that return both passes and failures despite no changes to the code or the test itself
 Fix the test so it runs consistently.
 
-
-
-### Environment
-ex: docker
+### CI Workflow
+rspec or docker?
 
 ### Sample Error Output:
 ```
 ```
 
-### How to Replicate
-Try running the test lots of times locally
-`bundle exec rspec spec/...`
-
 ### Questions? Join Slack!
 
 We highly recommend that you join us in slack https://rubyforgood.herokuapp.com/ #casa channel to ask questions quickly and hear about office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

Gemfile

@@ -43,6 +43,7 @@ gem "request_store"
 gem "sablon" # Word document templating tool for Case Court Reports
 gem "scout_apm"
 gem "sprockets-rails" # The original asset pipeline for Rails [https://github.com/rails/sprockets-rails]
+gem "stimulus-rails"
 gem "strong_migrations"
 gem "tzinfo-data", platforms: %i[mingw mswin x64_mingw jruby] # Windows does not include zoneinfo files, so bundle the tzinfo-data gem
 gem "active_model_serializers" # for JSON serialization
@@ -62,6 +63,7 @@ end
 
 group :development do
   gem "annotate" # for adding db field listings to models as comments
+  gem "bundler-audit" # for checking for security issues in gems
   gem "letter_opener" # Opens emails in new tab for easier testing
   gem "spring" # Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring
   gem "spring-commands-rspec"
@@ -79,7 +81,7 @@ group :test do
   gem "rake"
   gem "selenium-webdriver"
   gem "simplecov"
-  gem "webdrivers" # easy installation and use of web drivers to run system tests with browsers
+  gem "docx"
 end
 
 # gem "pdf-reader", "~> 2.9"

Gemfile.lock

@@ -100,13 +100,16 @@ GEM
       parser (>= 2.4)
       smart_properties
     bindex (0.8.1)
-    brakeman (6.0.0)
-    bugsnag (6.25.2)
+    brakeman (6.0.1)
+    bugsnag (6.26.0)
       concurrent-ruby (~> 1.0)
     builder (3.2.4)
     bullet (7.0.7)
       activesupport (>= 3.0.0)
       uniform_notifier (~> 1.11)
+    bundler-audit (0.9.1)
+      bundler (>= 1.2.0, < 3)
+      thor (~> 1.0)
     byebug (11.1.3)
     capybara (3.39.2)
       addressable
@@ -160,6 +163,9 @@ GEM
       devise (>= 4.6)
     diff-lcs (1.5.0)
     docile (1.4.0)
+    docx (0.8.0)
+      nokogiri (~> 1.13, >= 1.13.0)
+      rubyzip (~> 2.0)
     domain_name (0.5.20190701)
       unf (>= 0.0.5, < 1.0.0)
     dotenv (2.8.1)
@@ -254,7 +260,7 @@ GEM
     llhttp-ffi (0.4.0)
       ffi-compiler (~> 1.0)
       rake (~> 13.0)
-    lograge (0.12.0)
+    lograge (0.13.0)
       actionpack (>= 4)
       activesupport (>= 4)
       railties (>= 4)
@@ -272,12 +278,12 @@ GEM
     method_source (1.0.0)
     mini_magick (4.11.0)
     mini_mime (1.1.2)
-    minitest (5.18.1)
+    minitest (5.19.0)
     multi_xml (0.6.0)
     multipart-post (2.3.0)
     net-http-persistent (4.0.1)
       connection_pool (~> 2.2)
-    net-imap (0.3.6)
+    net-imap (0.3.7)
       date
       net-protocol
     net-pop (0.1.2)
@@ -287,11 +293,11 @@ GEM
     net-smtp (0.3.3)
       net-protocol
     nio4r (2.5.9)
-    nokogiri (1.15.2-arm64-darwin)
+    nokogiri (1.15.3-arm64-darwin)
       racc (~> 1.4)
-    nokogiri (1.15.2-x86_64-darwin)
+    nokogiri (1.15.3-x86_64-darwin)
       racc (~> 1.4)
-    nokogiri (1.15.2-x86_64-linux)
+    nokogiri (1.15.3-x86_64-linux)
       racc (~> 1.4)
     noticed (1.6.3)
       http (>= 4.0.0)
@@ -317,10 +323,10 @@ GEM
     public_suffix (5.0.1)
     puma (6.3.0)
       nio4r (~> 2.0)
-    pundit (2.3.0)
+    pundit (2.3.1)
       activesupport (>= 3.0.0)
     racc (1.7.1)
-    rack (2.2.7)
+    rack (2.2.8)
     rack-attack (6.6.1)
       rack (>= 1.0, < 3)
     rack-cors (2.0.1)
@@ -367,7 +373,7 @@ GEM
     responders (3.1.0)
       actionpack (>= 5.2)
       railties (>= 5.2)
-    rexml (3.2.5)
+    rexml (3.2.6)
     rspec-core (3.12.2)
       rspec-support (~> 3.12.0)
     rspec-expectations (3.12.3)
@@ -436,13 +442,15 @@ GEM
     standard (1.5.0)
       rubocop (= 1.23.0)
       rubocop-performance (= 1.12.0)
-    strong_migrations (1.5.0)
+    stimulus-rails (1.2.1)
+      railties (>= 6.0.0)
+    strong_migrations (1.6.0)
       activerecord (>= 5.2)
     thor (1.2.2)
     timeout (0.4.0)
     traceroute (0.8.1)
       rails (>= 3.0.0)
-    twilio-ruby (6.2.0)
+    twilio-ruby (6.3.1)
       faraday (>= 0.9, < 3.0)
       jwt (>= 1.5, < 3.0)
       nokogiri (>= 1.6, < 2.0)
@@ -453,7 +461,7 @@ GEM
     unf_ext (0.0.8.2)
     unicode-display_width (2.4.2)
     uniform_notifier (1.16.0)
-    view_component (3.3.0)
+    view_component (3.5.0)
       activesupport (>= 5.2.0, < 8.0)
       concurrent-ruby (~> 1.0)
       method_source (~> 1.0)
@@ -464,10 +472,6 @@ GEM
       activemodel (>= 6.0.0)
       bindex (>= 0.4.0)
       railties (>= 6.0.0)
-    webdrivers (5.2.0)
-      nokogiri (~> 1.6)
-      rubyzip (>= 1.3.0)
-      selenium-webdriver (~> 4.0)
     webmock (3.18.1)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
@@ -478,7 +482,7 @@ GEM
     websocket-extensions (0.1.5)
     xpath (3.2.0)
       nokogiri (~> 1.8)
-    zeitwerk (2.6.8)
+    zeitwerk (2.6.10)
 
 PLATFORMS
   arm64-darwin-20
@@ -500,6 +504,7 @@ DEPENDENCIES
   brakeman
   bugsnag
   bullet
+  bundler-audit
   byebug
   capybara
   capybara-screenshot
@@ -510,6 +515,7 @@ DEPENDENCIES
   delayed_job_active_record
   devise
   devise_invitable
+  docx
   dotenv-rails
   draper
   erb_lint
@@ -552,13 +558,13 @@ DEPENDENCIES
   spring-commands-rspec
   sprockets-rails
   standard (= 1.5.0)
+  stimulus-rails
   strong_migrations
   traceroute
   twilio-ruby
   tzinfo-data
   view_component
   web-console (>= 3.3.0)
-  webdrivers
   webmock
 
 RUBY VERSION

README.md

@@ -28,7 +28,7 @@ A CASA (Court Appointed Special Advocate) is a role where a volunteer advocates
     - [Common issues](#common-issues)
   - [Running the App / Verifying Installation](#running-the-app--verifying-installation)
 - [Other Documentation](#other-documentation)
-- [required acknowledgement](#required-acknowledgement)
+- [Acknowledgements](#acknowledgements)
 - [Communication and Collaboration](#communication-and-collaboration)
 - [Feedback](#feedback)
 
@@ -201,6 +201,12 @@ Test coverage is run by simplecov on all builds and aggregated by CodeClimate
 
 If additional work arises from your pull request that is outside the scope of the issue it resolves, please open a new issue.
 
+**Stimulus**
+
+[Issue 5016](https://github.com/rubyforgood/casa/issues/5016) started a refactor of Javascript to use 
+[Hotwire's Stimulus](https://stimulus.hotwired.dev/handbook/origin). To see if it's working for you, go to 
+`/casa_cases` and see **Stimulus is working!** in your browser console.
+
 **Post-deployment tasks**
 
 We are using [After Party](https://github.com/theSteveMitchell/after_party) to
@@ -228,10 +234,10 @@ There is a `doc` directory at the top level that includes:
 * [productsense.md](doc/productsense.md)(for team leads & product interested contributors)
 * [SECURITY.md](doc/SECURITY.md)
 
-# required acknowledgement
+# Acknowledgements
 
 Thank you to [Scout](https://ter.li/h8k29r) for letting us use their dashboard for free!
-[![Scout](https://user-images.githubusercontent.com/578159/165240278-c2c0ac30-c86f-4b67-9da6-e6a5e4ab4c37.png)](https://ter.li/h8k29r)
+[<img src="https://user-images.githubusercontent.com/578159/165240278-c2c0ac30-c86f-4b67-9da6-e6a5e4ab4c37.png" width="400" height="400" />](https://ter.li/h8k29r)
 
 # Communication and Collaboration