Get login duration from backend #4830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
erb
javascript
ErinClaudio
force-pushed
the
get-login-duration-from-backend
branch
from
701b190
to
c8c9616
Compare
ErinClaudio
force-pushed
the
get-login-duration-from-backend
branch
3 times, most recently
from
efebf6b
to
d3ad20a
Compare
|
ErinClaudio
force-pushed
the
get-login-duration-from-backend
branch
2 times, most recently
from
d5d31c6
to
c5fbc53
Compare
ErinClaudio
force-pushed
the
get-login-duration-from-backend
branch
from
c5fbc53
to
c50a776
Compare
ErinClaudio
requested review from
compwron,
FireLemons and
littleforest
as code owners
ErinClaudio
requested review from
FireLemons and
compwron
and removed request for
compwron and
FireLemons
littleforest
reviewed
Aug 4, 2023
| end | ||
|
|
||
| xit "warns the user two mintues before logout", js: true do | ||
| end |
There was a problem hiding this comment.
@ErinClaudio this looks good! Can you just remove this spec on line 15 if we are not going to test for it?
There was a problem hiding this comment.
you got it and Thank you
There was a problem hiding this comment.
@littleforest Thank you for the review. When you have a moment please
ErinClaudio
force-pushed
the
get-login-duration-from-backend
branch
from
1022cde
to
b3a81b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves ##4725
What changed, and why?
config.timeout_in = 3.hourshas been passed into hereHow will this affect user permissions?
How is this tested? (please write tests!) 💖💪
here
I will need to include the Jasmine gem per Shen's guidance to create a test that simulates the passage of time.
This task has been created as a new issue ticket.
This is why the second test has not yet been completed.
Screenshots please :)
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
Feedback please? (optional)
We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9
Is it better to list more or fewer reviewers? Not sure what is best practice for Casa
Thank you