Expense option bug fix #4899
Merged
Expense option bug fix #4899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danaguilar
requested review from
compwron,
FireLemons and
littleforest
as code owners
github-actions
bot
added
erb
ruby
|
Haven't been able to reproduce that docker failure on my own docker tests yet. Figure it'll be one of those things that we'll tackle with the flaky bug tests issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #4890
What changed, and why?
Previous branch was changing the FeatureFlag directly, which was causing any admin to enable/disable the additional expense option for the entire application. That change was reverted and instead a column was added to the CasaOrg table that would enable/disable the additional expense option at a per organization level. This combined with the FeatureFlag was used for a new policy that took the place of the old FeatureFlag.
Also the System Settings page was removed and the ability to enable/disable additional expenses was added to the
edit OrganizationpageHow will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Current tests were updated make use of this change
Screenshots please :)