-
-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5039 Remove deprecated learning_style column from learning_hour #5048
Merged
littleforest
merged 6 commits into
main
from
5039-remove-deprecated-learning_type-column-from-learning_hour
Jul 30, 2023
Merged
5039 Remove deprecated learning_style column from learning_hour #5048
littleforest
merged 6 commits into
main
from
5039-remove-deprecated-learning_type-column-from-learning_hour
Jul 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@schoork can you fix merge conflicts? |
…from-learning_hour
littleforest
approved these changes
Jul 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
README.md
Outdated
``` | ||
|
||
Then you can write a ticket to remove this line after the migration has been deployed to prod. You can see | ||
[Issue 5039](https://github.com/rubyforgood/casa/issues/5039) for an example of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this!
littleforest
deleted the
5039-remove-deprecated-learning_type-column-from-learning_hour
branch
July 30, 2023 15:42
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #5039
What changed, and why?
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
N/A, although updated a test
Screenshots please :)
N/A
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
Feedback please? (optional)
We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9