Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5039 Remove deprecated learning_style column from learning_hour #5048

Conversation

schoork
Copy link
Collaborator

@schoork schoork commented Jul 30, 2023

What github issue is this PR for, if any?

Resolves #5039

What changed, and why?

  • Removed column
  • Updated test
  • Created a final issue to deal with cleanup post deployment (added a note about this in README, too)

How will this affect user permissions?

  • Volunteer permissions: None
  • Supervisor permissions: None
  • Admin permissions: None

How is this tested? (please write tests!) 💖💪

N/A, although updated a test

Screenshots please :)

N/A

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/
alt text

Feedback please? (optional)

We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9

@schoork schoork linked an issue Jul 30, 2023 that may be closed by this pull request
@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Jul 30, 2023
@littleforest
Copy link
Collaborator

@schoork can you fix merge conflicts?

Copy link
Collaborator

@littleforest littleforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

README.md Outdated
```

Then you can write a ticket to remove this line after the migration has been deployed to prod. You can see
[Issue 5039](https://github.com/rubyforgood/casa/issues/5039) for an example of this.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this!

@littleforest littleforest merged commit 20b7077 into main Jul 30, 2023
12 checks passed
@littleforest littleforest deleted the 5039-remove-deprecated-learning_type-column-from-learning_hour branch July 30, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated learning_type column from learning_hour
2 participants