Bulk Court Dates #5060
Merged
Bulk Court Dates #5060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Case groups contain related cases * Bulk court dates can create a court date for all cases in a case group #4997
github-actions
bot
added
ruby
kcdragon
commented
Jul 30, 2023
|
|
||
| def set_court_report_due_date | ||
| if date.present? && court_report_due_date.blank? | ||
| self.court_report_due_date = date - 3.weeks |
There was a problem hiding this comment.
This used to be in the controller but since we need it in both controllers I think it makes more sense to be in the model
kcdragon
commented
Jul 30, 2023
| private | ||
|
|
||
| def set_court_report_due_date | ||
| if date.present? && court_report_due_date.blank? |
There was a problem hiding this comment.
I added a conditional for court_report_due_date.blank?. Without this, the value entered in the Court Report Due Date in the UI won't have any affect
kcdragon
commented
Jul 30, 2023
kcdragon
commented
Jul 30, 2023
|
I'll work on finishing the PR this week |
|
@littleforest This is ready for another look when you get a chance. |
littleforest
approved these changes
Aug 4, 2023
| FactoryBot.define do | ||
| factory :case_group_membership do | ||
| case_group { create(:case_group) } | ||
| casa_case { create(:casa_case) } |
There was a problem hiding this comment.
You can simplify this and just call the association, and it will automatically create the association:
factory :case_group_membership do
case_group
casa_case
end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #4997
What changed, and why?
How will this affect user permissions?
How is this tested? (please write tests!) 💖💪
Screenshots please :)
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
Feedback please? (optional)
We are very interested in your feedback! Please give us some :) https://forms.gle/1D5ACNgTs2u9gSdh9