Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix system volunteers/edit flaky spec #5064

Merged
merged 4 commits into from
Jul 30, 2023
Merged

Fix system volunteers/edit flaky spec #5064

merged 4 commits into from
Jul 30, 2023

Conversation

littleforest
Copy link
Collaborator

What github issue is this PR for, if any?

Resolves #5063

What changed, and why?

  • Removed a system spec that was already present as a view spec
  • Scrolled to the element before clicking it in hopes that it will be in view

@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Jul 30, 2023
@littleforest littleforest merged commit 02ca98d into main Jul 30, 2023
12 checks passed
@littleforest littleforest deleted the 5063-system-voluntters-edit-flaky-spec branch July 30, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compwron compwron Awaiting requested review from compwron compwron is a code owner

@FireLemons FireLemons Awaiting requested review from FireLemons FireLemons is a code owner

Assignees
No one assigned
Labels
ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Flaky Test spec/system/volunteers/edit_spec.rb:178
1 participant
@littleforest