Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provided the fix for flaky specs #5068

Merged
merged 1 commit into from
Jul 30, 2023
Merged

provided the fix for flaky specs #5068

merged 1 commit into from
Jul 30, 2023

Conversation

Br0k3nh4nd012
Copy link
Contributor

What GitHub issue is this PR for, if any?

Resolves 5050

What changed, and why?

  • used match_array instead of eql while comparing the array elements in the rspec.
  • Fix flaky spec.

@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Jul 30, 2023
littleforest
littleforest approved these changes Jul 30, 2023
View reviewed changes
Copy link
Collaborator

@littleforest littleforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@littleforest
Copy link
Collaborator

Please lint!

@littleforest littleforest merged commit f757547 into rubyforgood:main Jul 30, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littleforest littleforest littleforest approved these changes

@compwron compwron Awaiting requested review from compwron compwron is a code owner

@FireLemons FireLemons Awaiting requested review from FireLemons FireLemons is a code owner

Assignees
No one assigned
Labels
ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Flaky Test with spec/models/case_contact_spec.rb:453
2 participants
@Br0k3nh4nd012 @littleforest