Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused languages_users table from db #5104

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

FireLemons
Copy link
Collaborator

What changed, and why?

Deleted languages_users table from db because I suspect user_languages is used instead.

How is this tested? (please write tests!) 💖💪

Adding a language to a user only makes a row in the latter table
image
image

Do not merge until we can confirm the prod version of languages_users has no rows

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Aug 9, 2023
@FireLemons
Copy link
Collaborator Author

The prod data says the languages_users table does have rows but the user_languages contains all the rows the languages_users table has with additional rows from later in time.

See: 43bc4e9

I think it's safe to drop the unused table

@FireLemons FireLemons marked this pull request as ready for review August 12, 2023 18:57
@FireLemons FireLemons merged commit f733944 into rubyforgood:main Aug 12, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant