Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: quiet sass deprecation warnings #6027

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

elasticspoon
Copy link
Collaborator

We have a lot of these in the app atm:

Deprecation Warning: Sass's behavior for declarations that appear after nested
rules will be changing to match the behavior specified by CSS in an upcoming
version. To keep the existing behavior, move the declaration above the nested
rule. To opt into the new behavior, wrap the declaration in `& {}`.

More info: https://sass-lang.com/d/mixed-decls

    ┌──> node_modules/bootstrap/scss/_type.scss
40  │       font-weight: $display-font-weight;
    │       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ declaration
    ╵
    ┌──> node_modules/bootstrap/scss/vendor/_rfs.scss
136 │ ┌     @media (#{$rfs-mq-property-width}: #{$rfs-mq-value}) {
137 │ │       @content;
138 │ │     }
    │ └─── nested rule
    ╵
    node_modules/bootstrap/scss/_type.scss 40:5  @import
    bootstrap/scss/bootstrap.scss 17:9           @use
    app/assets/stylesheets/application.scss 3:1  root stylesheet

This is because sass added those in 1.77.7 but bootstrap is not up to date to that yet.

Thus, we will pin sass to 1.77.6 until bootstrap 5.3.4 is out to silence sass deprecation warnings.

See this issue on bootstrap for details: twbs/bootstrap#40621

Keep this locked to 1.77.6 until bootstrap 5.3.4 is out
to silence sass deprecation warnings.

See this issue on bootstrap for details:
twbs/bootstrap#40621
@github-actions github-actions bot added dependencies Pull requests that update a dependency file javascript for use by Github Labeler to mark pull requests that update Javascript code labels Sep 7, 2024
@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Sep 8, 2024
@elasticspoon elasticspoon marked this pull request as ready for review September 8, 2024 00:59
@elasticspoon elasticspoon merged commit 883813c into main Sep 9, 2024
19 checks passed
@elasticspoon elasticspoon deleted the fix/sass-deprecation-warnings branch September 9, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript for use by Github Labeler to mark pull requests that update Javascript code ruby Pull requests that update Ruby code Tests! 🎉💖👏
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant