Add extra day to case contact date validation #6047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses (temporarily?) issue where validation failed when user selected current day in browser. Date could be wrong for those situations, however. Also uses Time.zone.tomorrow vs Date.tomorrow
thejonroberts
requested review from
compwron,
FireLemons and
elasticspoon
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Addresses #5860
What changed, and why?
Addresses (temporarily?) issue where validation failed when user selected current day in browser.
Date could now be wrong (tomorrow) for those situations, however. Also changes Date.tomorrow to Time.zone.tomorrow to possibly to mitigate that.
How is this tested? (please write tests!) 💖💪
Current tests only. Cannot find a decent solution for setting capybara browser driver timezones to tests the difference between browser and server. Possibly could add request spec sending date as browser would send... but unsure how to account for TimeZone differences there?