Update stimulus rails nested-form & switch to namespaced version #6057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thejonroberts
requested review from
schoork,
FireLemons,
elasticspoon and
compwron
as code owners
github-actions
bot
added
dependencies
elasticspoon
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
import RailsNestedForm from '@stimulus-components/rails-nested-form' should this be in alpha order along with the other controllers?
There was a problem hiding this comment.
that makes sense, i was trying to differentiate that it is imported from a library
2 tasks
thejonroberts
deleted the
contact-form-refactor-prep-stimulus-nested-package
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Preparation for case contact form overhaul
What changed, and why?
Update
stimulus-rails-nested-formand switch to the namespaced package@stimulus-components/rails-nested-form. The package was using the old form of the npm name. That seems to be the reason for the major version change, no breaking changes in the changelog here.package info here.
How is this tested? (please write tests!) 💖💪
No new functionality, existing tests should do.