Rails 7.2.2 update #6099
Open
Rails 7.2.2 update #6099
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
except Sablon (caused a spec fail)
except sablon update - broke a spec
github-actions
bot
added
the
dependencies
thejonroberts
requested review from
compwron,
FireLemons and
elasticspoon
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
No issue
What changed, and why?
Update Rails version from 7.2.1 to 7.2.2.
I was looking into updating to rails 8, but had to stop here.
rswagandflipper-active_recordgems aren't compatible yet. It doesn't seem like the api/rswag in use? only has sign in endpoint. But flipper is being used for sure.erb_lint had a few post-update deprecation warnings that were fixed - renamed yml file, changed bin/lint call to the 'correct' executable.
How is this tested? (please write tests!) 💖💪
Current specs.