Replace exists? with check for count

rubyforgood · Sep 22, 2024 · a643e2a · a643e2a
1 parent 71b84d7
commit a643e2a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/controllers/requests_controller.rb b/app/controllers/requests_controller.rb
@@ -8,7 +8,7 @@ def index
                 .undiscarded
                 .during(helpers.selected_range)
                 .class_filter(filter_params)
-    @unfulfilled_requests = current_organization.requests.where(status: [:pending, :started])
+    @unfulfilled_requests_count = current_organization.requests.where(status: [:pending, :started]).count
     @paginated_requests = @requests.page(params[:page])
     @calculate_product_totals = RequestsTotalItemsService.new(requests: @requests).calculate
     @items = current_organization.items.alphabetized

diff --git a/app/views/requests/index.html.erb b/app/views/requests/index.html.erb
@@ -61,10 +61,10 @@
                 <%= clear_filter_button %>
                 <%= modal_button_to("#calculateTotals", {text: "Calculate Product Totals", icon: nil, size: "md", type: "success"}) %>
                 <span class="float-right">
-                  <% if @unfulfilled_requests.exists? %>
+                  <% if @unfulfilled_requests_count > 0 %>
                     <%= print_button_to(
                       print_unfulfilled_requests_path(format: :pdf),
-                      text: "Print Unfulfilled Picklists (#{@unfulfilled_requests.size})",
+                      text: "Print Unfulfilled Picklists (#{@unfulfilled_requests_count})",
                       size: "md") %>
                   <% end %>
                   <%= download_button_to(requests_path(format: :csv, filters: filter_params.merge(date_range: date_range_params)), {text: "Export Requests", size: "md"}) if @requests.any? %>