Fix error handling on registration

[cielf]

Summary

Mistakes on the registration form die without feedback. Fix this.

Why fix it?

Making onboarding less error-prone. Reducing support load

Details

Recreating the problem

On local, , Click on "Register your bank here for free", Choose "I am an Essentials Bank" . Fill in all the mandatory fields except request details. Submit.

It goes to the screen with the choice between bank and partner, With no feedback that anything is wrong. (It actually flashes something, but too quick to read.)

It should, instead, go to the screen with the registration details. There should be an error message at the top, as well as the errors that currently show there if you re-choose bank.

Updated knowledge

Apparently it does quickly flash the expected screen, but then goes to the screen with the choice between bank and partner

Criteria for completion

• If there is an error on filling out the registration form, the registration details appear, with error messaging.
• tests to support this behaviour

[cielf]

This looks like a javascript thing on the new.html.

[rosenwu]

@cielf Hi, I think we can try this, can you assign this to me?

[dorner]

You got it!

[github-actions]

This issue has been inactive for 243 hours (10.13 days) and will be automatically unassigned after 117 more hours (4.88 days).

[github-actions]

This issue has been inactive for 363 hours (15.13 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.

[nadineah]

Can I take a shot at this issue?

[cielf]

@nadineah Go for it!

[lisawan2-cmu-F24]

Hi! I think also there is a similar issue when submitting a blank registration form. It will go back to the original state. And then after clicking on the "I am an Essentials Bank" radio button again, the error appears.

[cielf]

@Gemini010815 Indeed -- I think that a blank registration form would be a mistake, and would hopefully be covered by the fix for this.

[github-actions]

This issue has been inactive for 245 hours (10.21 days) and will be automatically unassigned after 115 more hours (4.79 days).

[github-actions]

This issue has been inactive for 365 hours (15.21 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.

[westonio]

Hi @cielf & @scooter-dangle , I recently joined RFG in Slack and would love to take this on as my first issue.

I experimented on my end and already have a working fix for this. Would you mind assigning this one to me?

[dorner]

Go for it!

[westonio]

Awesome, thank you for the help getting this assigned to me @dorner 😄 🙌

[github-actions]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.