-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Investigation] Current bootstrap (4) is past EOL…upgrade to Bootstrap 5 #3450
Comments
Picking this up along with @h-m-m. |
Per the PR -- bootstrap is upgraded! But we need to do a visual regression test (and likely fix a conflict or two as we are doing parallel work). The PR has a big checklist of areas / types of things to check. |
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned. |
Automatically unassigned after 7 days of inactivity. |
Summary
To stay current with the most recent bootstrap APIs and functionality we need to upgrade from bootstrap 4 to bootstrap 5. The challenge is that we are currently using a theme, AdminLTE, but that theme has not released a bootstrap 5 version yet. We like someone to do a research spike and see if the current working bootstrap 5 branch of AdminLTE is ready enough for us to use and see if we are able to move to the newest version of bootstrap.
Why update?
Very minor potential for security issues due to no longer getting patches.
Primarily though, having such an outdated version of a primary library will make it more difficult for new contributors to dive in and help out as bootstrap continues to evolve and add new and different classes/ids/etc that contributors will expect to exist but are not present on the prior version of bootstrap.
Details
Here is a link to the bootstrap 5 branch of AdminLTE.
Here is a link to the bootstrap 5 upgrade documentation.
Notes:
Just a reminder that the application is now using importmaps.
Initial step:
Determine the status of Admin LTE support for Bootstrap 5. E.g., how far away is the in-progress branch from supporting what we need? It is possible that since AdminLTE supports multiple frameworks (React, Vue, etc) that the base stylings are already finished.
Criteria for completion
application.html.erb
,_lte_sidebar.html.erb
,_lte_navbar.html.erb
as well as a single page in the application. Link to the branch as well as screenshots.The text was updated successfully, but these errors were encountered: