Clean up profiles without partners

[cielf]

Summary

data-cleanup -- partner profiles without partners

Why address

A kindness to future supporters/devs

Details

There are a number of profiles without partners. These appear to be a holdover from partnerbase days. Let's clean them up!

Notes

Original commentary from investigation phase.

I don't think you could access any of these at this point, but check. (you might be able to get at it some weird way as a bank, you know, by entering the profile id if you are the right bank, but probably not through the normal UI)

This is likely a carry forward from some long long ago issue that was brought forward when the dbs were combined,. I expect none of these have been accessed in ahem some time.

Let's take a look at whether this is affecting any banks that are active, first.

Initial investigation indicates there are 141 profiles without partners? some of which are clearly bogus (partner 999,999 seems suspect, for instance.)

Criteria completion

• Script that will clean up the profiles, tested against production copy to ensure only disconnected profiles are deleted.

[dorner]

So there is definitely something relatively recent going on here - but my hunch is it's benign.

Partner profile ID: 3682

belongs to organization ID: 224 (which was only created in January).

It also belongs to partner ID 3812, which does not exist. This seems to indicate that the partner was deleted, but the profile wasn't.

There is a dependent: :destroy option on the profile, meaning if you actually call destroy on the partner, it should also destroy the profile.

Long story short, it's very hard to figure out what happened here without accessing app logs. And unfortunately we don't keep the app logs for the period of time we'd need to figure this out.

We really need something like Logstash or Flume to be able to view and search our older logs.

[cielf]

Adding that need as a topic for Sunday's meeting.

[cielf]

@dorner That profile has the same name as 3811, which is suspiciously close to 3812

[cielf]

There are two cases in the immediate vicinity that have doubled names. It may be "when you have a hammer everything looks like a nail", but I'm wondering if this is another double-click situation.

[dorner]

Interesting! Wondering if it's a double-click plus race condition where it creates two partners, rolls back one of them (since there is a uniqueness validation on name) but leaves the profile as is. Not sure how that's possible since the partner + profile creation is inside a transaction.

In any case, since we've fixed double clicks across the board with #3612 we can monitor this to see if it happens again. My hunch is no, and it seems like these profiles are basically just garbage data in any case.

[github-actions]

This issue has been inactive for 249 hours (10.38 days) and will be automatically unassigned after 111 more hours (4.63 days).

[github-actions]

This issue has been inactive for 369 hours (15.38 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.

[dorner]

@cielf any further action needed here?

[cielf]

@dorner There are still 141, so the problem hasn't gotten any worse. How do we feel about cleaning them out?

[dorner]

Sounds good to me! Want to change this from an investigation to a cleanup ticket?

[cielf]

Yes. Changing in place.