Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thank everyone when the release goes out automagically. #3726

Closed
1 task
cielf opened this issue Jul 9, 2023 · 9 comments · Fixed by #3807
Closed
1 task

Thank everyone when the release goes out automagically. #3726

cielf opened this issue Jul 9, 2023 · 9 comments · Fixed by #3807
Labels
Help Wanted Groomed + open to all! stale

Comments

@cielf
Copy link
Collaborator

cielf commented Jul 9, 2023

Summary

We'd like to notify everyone who contributed to a production release.

Why?

Although we sometimes do this ourselves manually, we don't always have the cycles to do it. It's nice to know when your changes go out!

Details

This could be a process that is run manually when the release is done, or potentially something that automatically happens as part of the release.

Wording should be something like "@your_id: Your PR [PR title ] is part of today's Human Essentials production release. Thank you very much for your contribution!"

Reference: https://github.com/marketplace/actions/release-commenter

Criteria for completion

  • we can easily (or even automatically) notify everyone who wrote code for a release that their changes are in.
@cielf cielf added core team Groomed but likely needs expert knowledge Help Wanted Groomed + open to all! and removed core team Groomed but likely needs expert knowledge labels Jul 9, 2023
@chriskarlin
Copy link
Contributor

Would like to give this a go!
(can't seem to assign the issue to me atm)

@cielf
Copy link
Collaborator Author

cielf commented Jul 15, 2023

Alright!

@dorner
Copy link
Collaborator

dorner commented Jul 28, 2023

Looks like the existing action doesn't support either the PR opener or the PR name in the body. Might need to add those features before we can do this.

@chriskarlin
Copy link
Contributor

chriskarlin commented Jul 30, 2023

Will be looking into this. Since the comment is added to the PR itself maybe the PR name is not required?
Either way, am looking into opening a PR for adding more inputs.

Created a draft PR in the meanwhile.

@github-actions
Copy link
Contributor

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

Automatically unassigned after 7 days of inactivity.

@chriskarlin
Copy link
Contributor

ooooops, forgot about this 😅

Got a WIP PR for adding the author and title to the GHA here. Currently still not fully working, as I was getting permission issues "Failed to load title\" data-id=\"1885795064\" data-permission-text=\"Title is private\". Will be taking another look this afternoon

@chriskarlin
Copy link
Contributor

Marked PR ready for review. Had to end up using my own fork of the GitHub action in order to use the new feature of author and title template variables. Please see PR for explanations

dorner pushed a commit that referenced this issue Oct 12, 2023
* ci: add workflow file for release contribution notifier

* Use own fork of github-release-commenter
@github-actions
Copy link
Contributor

@N/A: Your PR/Issue N/A is part of today's Human Essentials production release: 2023.10.15.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted Groomed + open to all! stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants