-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] On Donation, drop down changes to show item number rather than description on edit error. It shouldn't. #4172
Labels
Comments
Hey there @cielf I would love to try and solve this |
Give it a go! |
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned. |
Automatically unassigned after 7 days of inactivity. |
Can I take a swing at this? |
You may! |
jimmyli97
added a commit
to jimmyli97/human-essentials
that referenced
this issue
Jun 27, 2024
…nation amount edit
jimmyli97
added a commit
to jimmyli97/human-essentials
that referenced
this issue
Jun 27, 2024
…unt edit * direct call to render doesn't load @Items causing partial to be unable to match item IDs to item names, resulting in displaying numbers * replace with redirect to edit
Automatically unassigned after 7 days of inactivity. |
2 tasks
awwaiid
added a commit
that referenced
this issue
Aug 4, 2024
Fix #4172 donation validation display error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
If you have a validation error on saving the donation, the dropdownfor the item changes to a number rather than the item name. It should still show the item name.
Details
Recreation
I've been able to recreate this by producing an error where you can't reduce the quantity because it would take the inventory negative.
To do that:
Enter a donation with a large number of some item.
Next, enter a distribution that reduces the inventory to less than the number of items in the donation
Then, edit the donation. Reduce the number of items in the donation to 1. (this doesn't have to realistic, we're just trying to produce the error.)
Save. You should get an error, and a screen similar to this (the numbers will obviously be different)
Instead, you should be seeing the item name where it shows "1" in the above screenshot.
Criteria for completion
The text was updated successfully, but these errors were encountered: