Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the ability for the superuser to delete users #4434

Closed
4 tasks
cielf opened this issue Jun 9, 2024 · 2 comments · Fixed by #4480
Closed
4 tasks

Remove the ability for the superuser to delete users #4434

cielf opened this issue Jun 9, 2024 · 2 comments · Fixed by #4480
Assignees
Labels
Good First Issue Suitable for users that are newer or less experienced

Comments

@cielf
Copy link
Collaborator

cielf commented Jun 9, 2024

Summary

Remove the button for deleting users from the admin's user list

Why?

We don't need it, there is potential confusion, and if it is used on a partner who has ever made a requests, we get a 500.

Details

Remove the button for deleting users from the admin user index (N.B. not the button for deleting roles on the individual view)
To see this, sign in as superadmin@example.com, click Users in the left-hand menu, then All Users

Criteria for completion

  • the button is removed
  • tests modified to reflect the new behaviour
  • tests pass
  • screenshots in the PR are a nice-to-have.
@cielf cielf added the Good First Issue Suitable for users that are newer or less experienced label Jun 9, 2024
@noah-puckett
Copy link
Contributor

Hello @cielf, could I try taking this on?

@cielf
Copy link
Collaborator Author

cielf commented Jun 18, 2024

Go for it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Suitable for users that are newer or less experienced
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants