4434 remove superuser delete functionality #4480
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4434
Description
Based on the description in this issue, I have removed the button for deleting users from the admin's user list.
While the issue description said only to remove the button, I have included a commit removing the functionality from the controller as well, which I am not certain is strictly necessary and would appreciate any feedback available.
Type of change
How Has This Been Tested?
I removed the delete button from the view, then locally ran the site and saw the button no longer rendered. I then added the button back and removed the controller logic to destroy a user, ran the site locally and clicked the delete button, which produced a
The action 'destroy' could not be found for Admin::UsersController
and did not delete the user.I removed the test that asserted functionality in that controller, ran the full test suite, and all tests passed.
Screenshots
Before button removal:
After button removal: