Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4434 remove superuser delete functionality #4480

Merged

Conversation

noah-puckett
Copy link
Contributor

Resolves #4434

Description

Based on the description in this issue, I have removed the button for deleting users from the admin's user list.

While the issue description said only to remove the button, I have included a commit removing the functionality from the controller as well, which I am not certain is strictly necessary and would appreciate any feedback available.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

I removed the delete button from the view, then locally ran the site and saw the button no longer rendered. I then added the button back and removed the controller logic to destroy a user, ran the site locally and clicked the delete button, which produced a The action 'destroy' could not be found for Admin::UsersController and did not delete the user.

I removed the test that asserted functionality in that controller, ran the full test suite, and all tests passed.

Screenshots

Before button removal:
Screenshot 2024-06-19 at 9 10 00 AM
After button removal:
Screenshot 2024-06-26 at 10 20 14 AM

@dorner
Copy link
Collaborator

dorner commented Jun 26, 2024

All good on my end - @cielf want to take a look at the UI?

@cielf
Copy link
Collaborator

cielf commented Jun 26, 2024

Will check tomorrow.

@cielf
Copy link
Collaborator

cielf commented Jun 27, 2024

Looks alright. Merging.

@cielf cielf merged commit 5c975a2 into rubyforgood:main Jun 27, 2024
20 checks passed
Copy link
Contributor

github-actions bot commented Jul 7, 2024

@noah-puckett: Your PR 4434 remove superuser delete functionality is part of today's Human Essentials production release: 2024.07.07.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the ability for the superuser to delete users
3 participants