-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more shortcuts to the date range selection -- last year, last 12 months #4518
Labels
Comments
cielf
added
Difficulty—Beginner
Difficulty—Intermediate
Help Wanted
Groomed + open to all!
and removed
Difficulty—Beginner
labels
Jul 14, 2024
Hi. 👋 It's been a minute. Can I try and pick this up? |
It is yours! |
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned. |
Automatically unassigned after 7 days of inactivity. |
This one has an outstanding PR that needs a little work - @pshong79 said it's ok if someone else takes it over the finish line. |
dorner
pushed a commit
that referenced
this issue
Nov 30, 2024
* changes to add "last 12 months" and "prior year" * Update spec for "Prior Year" and "Last 12 Months" * fix failing test and rubocop error * Fix filter by prior year and last 12 months specs --------- Co-authored-by: Cory Streiff <c.streiff@pm.me>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
We should have a couple more shortcuts on the date range selectors throughout the system --prior year, and last 12 months
Why?
At the beginning of each year, especially, the default "this year" is not very useful, and the banks have trouble getting the lists they want out of the system
Details
There are several places where we use date ranges -- many of the indices are filterable by date. I'm not sure if they are all using the same piece of code to specify the shortcuts-- I hope so!
Prior year --- this would be January 1 to December 31 of the calendar year before the current year
Last 12 months -- this would be going back 12 months from today (if today is July 14, 2024, the range should be July 15, 2023 to July 14, 2024).
Criteria for completion
The text was updated successfully, but these errors were encountered: