[BUG]: can't edit original storage location of a distribution when storage location has total inventory 0

[jimmyli97]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

If a distribution sets the storage location to total inventory 0 and read_events is enabled, the original storage location won't show up when editing the distribution. Submission fails with "Couldn't find StorageLocation with 'id'=". You have to get this error message before the storage location becomes visible again and you can properly save.

(Ran across this when testing DistributionCreateService)

Expected Behavior

You should be able to edit the distribution at the original storage location without having to go through the error

Steps To Reproduce

1. Enable read_events
2. Create a new storage location
3. Create a donation to that storage location, e.g. Adult Briefs (1)
4. Create a distribution which empties that storage location to total inventory 0, e.g. Adult Briefs (1)
5. Attempt to edit this distribution and select the original storage location

Criteria for Completion

• fix
• write test

Anything else?

Code of Conduct

• I've read the Code of Conduct and understand my responsibilities as a member of the Ruby for Good community