-
-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PACKS] # 9 Distribution printout for banks includes custom request units, if applicable #4404
Comments
cielf
added
Help Wanted
Groomed + open to all!
Difficulty—Beginner
and removed
Ruby for Good 2024 DC
Issues for RFG 2024 DC
labels
Jul 7, 2024
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned. |
Automatically unassigned after 7 days of inactivity. |
awwaiid
added a commit
that referenced
this issue
Oct 13, 2024
dorner
pushed a commit
that referenced
this issue
Oct 14, 2024
* Display units in distribution PDF as needed * Clean out some lint * Extract common display logic [#4404]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
Distribution printout for banks includes custom request units, if applicable.
Why
This is step #9 of adding the ability to specify "packs" versus "individual" for requests
Details
If any of the requested items have units selected
Add custom units to the requested amounts. This may require some adjustment in column widths
Hint
app/pdfs/distribution_pdf.rb
Visual aid
N.B.
All of the changes for PACKS must be implemented behind a flipper flag "enable_packs"
1/ Flipper works by enabling or disabling a tag (for the PACKS issues, that is enable_packs)
2/ Here is a code snippet illustrating how to use it in your code, with enable_packs as the example tag:
if Flipper.enabled?(:enable_packs)
// do the thing we are guarding with the tag
end
3/ How to check out if it works manually (with the example tag: enable_packs ):
You have to enable the flipper tag on your localhost (note - the tag is stored in your db, so if you reset your db you have to do it again)
localhost:3000/flipper
userid: admin
password: password
Sign In
Click: Add feature
enable_packs
Click: Add feature
Click: Fully enable
To set it back (to check that your nifty changes haven’t broken anything when the flag is off)
Sign in as above:
click on “enable_packs”
click “Delete”
type enable_packs in the “Are you sure” dialog and click ok
Criteria for completion
Background
The following sections have been identified as required for the PACKS implementation. These should be implemented in numerical order.
The text was updated successfully, but these errors were encountered: