Display units in distribution PDF as needed #4610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
dorner
requested changes
Sep 2, 2024
app/pdfs/distribution_pdf.rb
Outdated
Comment on lines
195
to
199
| request_qty = if Flipper.enabled?(:enable_packs) && request_item.unit | ||
| "#{request_item.quantity} #{request_item.unit.pluralize(request_item.quantity)}" | ||
| else | ||
| request_item.quantity || "" | ||
| end |
There was a problem hiding this comment.
Can we extract this into a method since it's doing the same thing twice?
dorner
approved these changes
Oct 14, 2024
|
@awwaiid: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #4404
I didn't end up trying to adjust column widths manually, just let it auto-fit.