3013: Consolidate users #3050
Merged
3013: Consolidate users #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwinthinks
reviewed
Jul 29, 2022
| if main_user.nil? | ||
| attrs = user.attributes.except('id').merge(discarded_at: nil) | ||
| # null constraint on name for User table doesn't exist for Partner User table | ||
| attrs['name'] ||= "CHANGEME" |
There was a problem hiding this comment.
Suggested change
| attrs['name'] ||= "CHANGEME" | |
| attrs['name'] ||= "CHANGEME" |
Could we guess the name using the email?
edwinthinks
reviewed
Jul 29, 2022
edwinthinks
reviewed
Jul 29, 2022
There was a problem hiding this comment.
@dorner nice work! I combed over the code and it looks pretty solid. I'am going to pull down the branch and test this on a copy of production as well.
|
@dorner I noticed a few things when testing.
Otherwise, I didn't see any other issues with this release. I think it is important though we communicate with our banks and partners that the login page is going to be different in advance. |
|
@edwinthinks Updated! New page looks like this: |
dorner
force-pushed
the
3013-consolidate-users-take2
branch
from
8d2fbdb to
fc99140
Compare
added 2 commits
July 29, 2022 16:04
edwinthinks
approved these changes
Jul 30, 2022
5 tasks
danielabar
added a commit
to danielabar/human-essentials
that referenced
this pull request
Jul 9, 2024
… warning on confirmation modal
danielabar
added a commit
to danielabar/human-essentials
that referenced
this pull request
Jul 19, 2024
… warning on confirmation modal
danielabar
added a commit
to danielabar/human-essentials
that referenced
this pull request
Jul 27, 2024
… warning on confirmation modal
danielabar
added a commit
to danielabar/human-essentials
that referenced
this pull request
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3013
Description
This change accomplishes the following:
partner_idto the User model.This change does not add the
punditandrolifygems, which would be an additional feature on top of this to enable things like partner admin roles.One thing I'm unsure about is if partner users are given a separate URL somewhere to log in, and if we have to forward that URL to the new single login page.
Type of change
How Has This Been Tested?
Local and unit tests.
Screenshots
TO DO: Run full test suite on CI and fix broken specs