Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix seeds organization address assignment #367

Merged
merged 2 commits into from
Jun 8, 2018

Conversation

mlpinit
Copy link
Member

@mlpinit mlpinit commented Jun 8, 2018

Resolves #1

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

Screenshots

@mlpinit mlpinit requested a review from armahillo June 8, 2018 00:35
db/seeds.rb Outdated
@@ -9,7 +9,7 @@

pdx_org = Organization.find_or_create_by!(short_name: "pdx_bank") do |organization|
organization.name = "PDX Diaper Bank"
organization.address = "P.O. Box 22613, Portland OR 97269"
# organization.address = "P.O. Box 22613, Portland OR 97269"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can fully remove it. The last migration:

class AddAddressFieldsToOrganization < ActiveRecord::Migration[5.1]
  def change
    add_column :organizations, :street, :string
    add_column :organizations, :city, :string
    add_column :organizations, :state, :string
    add_column :organizations, :zipcode, :string
    remove_column :organizations, :address
  end
end

removed the address column completely

Copy link
Collaborator

@awwaiid awwaiid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@armahillo armahillo merged commit f7de25b into master Jun 8, 2018
@armahillo armahillo deleted the fix-seeds-organization-address-assignment branch June 8, 2018 00:52
@armahillo armahillo added the Ruby for Good This Pull Request was created at a Ruby for Good event label May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ruby for Good This Pull Request was created at a Ruby for Good event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants