#3764: Fix profile attachments saving #3782
Conversation
There was a problem hiding this comment.
Hey @dorner. It might be a problem with my environment, but I am getting "This localhost page can't be found" when I try to open an uploaded file on my local.
Very light testing of counties looked ok (but would want to do more).
|
@cielf not sure what happened but I tried again and it looks like I was missing one more reload - reloading inside a transaction looks like it blows away the attachment changes even if it's already changed. Try now! |
|
@dorner Hrm. On my local, If you upload a file, and have counties not adding up to 100, and hit save, you, of course, get an error (as you should), but there is a link for the file, and if you click on it, you get one of those unpleasant "This localhost page can’t be found" errors. I wouldn't be surprised to learn that was always the case, of course. We probably haven't tested these in combo much. (This was with the determination letter) |
|
@cielf played around and it looks like this only happens on the edit screen itself when there was an error. If you refresh the edit page, it shows you the original attachment (the new one wasn't saved, which is correct) and it's fine. Not sure it's worth it to chase this bug. |
|
So... if I understand correctly, we would be in a better place than we originally were if we put this in without "chasing this bug". Given that, I say let's have @awwaiid take a look, then move on. |
patelkrunal31
force-pushed
the
3764-fix-attachments
branch
from
b2245ec to
b397852
Compare
|
@awwaiid Can you take a look at this one, please? |
|
@dorner: Your PR |
Tried this out and all the tests are still passing when I take the
reloadout, but attachments are saving again. Not sure why it was in there in the first place. Did some desultory manual testing as well and I couldn't find any problems.