-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Item Inventory for Banks with many locations #3784
Add Item Inventory for Banks with many locations #3784
Conversation
Hrm. @ChaelCodes Tried this with a copy of production data, and I'm not seeing the storage locations on Sylvia's Sisters |
Oh -- I see -- you have to click to expand them. Hrm. If I didn't immediately see that, the banks won't either (likely). What can we do to make it more obvious? It might be enough to put a note in the header ("Click for location breakdown") |
Except, when I click, it's expanding, but then going to the Item Information screen. I'm using Chrome FWIW. |
a92bbb9
to
27d84ec
Compare
So, I made the item names link to the items! But I also made clicking the row anywhere expand it. Maybe if I add a little icon at the end of the row to clue them in that they can click the row? Clicking the icon would expand it, but they'd figure out they could technically click anywhere on the row. |
Yeah... Maybe putting an explicit "Expand" button would work. Maybe the size of the View/edit/print/reclaim buttons that you would see in the distribution index. |
27d84ec
to
30cca38
Compare
Hey @ChaelCodes -- this is me being cautious -- but I just realized you're using AdminLTE, and I know there was something about AdminLTE not being ready for bootstrap5 in the issue that's prompted Howard's work there -- can you touch base with him, if you haven't already? |
I mentioned it to him, but I double-checked based on this comment. @h-m-m says it's okay because we're sticking with AdminLTE for now, and if we want to remove it, we'll have to do a whole site redesign, so it'll just be part of that larger effort.
I saw this after implementing +/- icons. The whole row is still clickable, but this hints that it expands. I think we definitely need to provide a hint/clue. Does this look better? |
04ff4c3
to
70f25b1
Compare
This makes sense. I want to run this past the stakeholder who mentioned the issue to make sure she doesn't expect to lose value by no longer being able to look down across an entire column. |
This is a good idea. We moved it into a separate tab - Item Inventory, to make sure that we didn't impact banks that can currently scan the whole column. |
8ebb337
to
16f1e24
Compare
The "Items, Quantity, and Location" table has a nasty horizontal scroll if the bank has many locations, which can be common for banks that allow volunteers to take inventory back to their residences to package into kits. This is very unwieldly for them, but other banks with few locations have a great scannable view of where their inventory is. We're reproducing this table with the locations collapsed under a heading for banks with many locations in a new tab to preserve the experience for banks with few locations. ExpandableTable from AdminLTE is being used to handle the expansion. Location is being stored slightly differently in the query to make it easier to access.
7904293
to
d160974
Compare
Nice…thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Let's mergeroo!
0c859f0
to
df90cac
Compare
df90cac
to
8d274a9
Compare
Resolves #3776
Description
Move to using an ExpandableTable from AdminLTE. The current table horizontally scrolls when there are too many locations configured for the organization. Instead, we'll show locations and quantities in a collapsible row when you click on the row. Also, add a link to the item, so they can access additional details about the item from the table.
Type of change
How Has This Been Tested?
Screenshots