Cuprite no retry #3786
Merged
Cuprite no retry #3786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scooter-dangle
approved these changes
Jul 29, 2023
awwaiid
force-pushed
the
cuprite-no-retry
branch
from
017b6c2 to
1f1a738
Compare
Conflicts: Gemfile Gemfile.lock spec/rails_helper.rb spec/system/organization_system_spec.rb
Conflicts: Gemfile.lock
Closed
The timeout here is browser setup time I think, not individual test timeouts.
Conflicts: Gemfile Gemfile.lock db/schema.rb spec/system/sign_in_system_spec.rb
Conflicts: Gemfile Gemfile.lock
|
I've run this a bunch of times and it is pretty stable. The most recent -- I ran the browser (system) specs 50 times. They failed twice -- once I'm not sure why, and the other because the github runner itself failed (didn't even start the specs). |
dorner
approved these changes
Jan 21, 2024
|
@awwaiid: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran this a bunch of times. In the most recent run the system specs were run 50 times in a row with 2 fails -- one was a javascript issue of some sort that I haven't been able to reproduce, the other was github runner itself failing.