Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add events to seeds + make DistributionCreateService consistent #3979

Merged
merged 3 commits into from
Dec 24, 2023

Conversation

dorner
Copy link
Collaborator

@dorner dorner commented Dec 20, 2023

This PR does the following:

  • Add events to seeded data by running all created data through the appropriate service rather than creating it manually.
  • Update DistributionCreateService to act the same as all other creation services by taking an ActiveRecord object rather than a set of parameters.

@dorner dorner requested review from awwaiid and cielf December 20, 2023 20:19
@cielf
Copy link
Collaborator

cielf commented Dec 20, 2023

@dorner Notes that it's failing the lint

@dorner
Copy link
Collaborator Author

dorner commented Dec 20, 2023

Fixed!

@cielf
Copy link
Collaborator

cielf commented Dec 21, 2023

@dorner I note that the initial Aggregate that I see has a lot of negative numbers. That may well be because the seed is not consistent. I note also that the Inventory and the Aggregate do not agree. Do we expect them to?

@dorner
Copy link
Collaborator Author

dorner commented Dec 21, 2023

They definitely should agree, and not have negative numbers. Let me look into it.

@dorner
Copy link
Collaborator Author

dorner commented Dec 21, 2023

Pushed a fix - was missing the initial SnapshotEvents.

@cielf
Copy link
Collaborator

cielf commented Dec 22, 2023

That looks better. I'm going to run a few of the test cases against this branch and see if anything else falls out.

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done some light manual testing on this (rebased onto main). The only bug I found is also already on staging (for the curious -- on edit, the storage location defaults to the first storage location). I'm ok with it going into staging. @awwaiid ?

Copy link
Collaborator

@awwaiid awwaiid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@awwaiid awwaiid merged commit 676ebdf into main Dec 24, 2023
12 checks passed
@awwaiid awwaiid deleted the fix-seeds branch December 24, 2023 15:06
Copy link
Contributor

@dorner: Your PR Add events to seeds + make DistributionCreateService consistent is part of today's Human Essentials production release: 2023.12.24.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants