-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add events to seeds + make DistributionCreateService consistent #3979
Conversation
@dorner Notes that it's failing the lint |
Fixed! |
@dorner I note that the initial Aggregate that I see has a lot of negative numbers. That may well be because the seed is not consistent. I note also that the Inventory and the Aggregate do not agree. Do we expect them to? |
They definitely should agree, and not have negative numbers. Let me look into it. |
Pushed a fix - was missing the initial SnapshotEvents. |
That looks better. I'm going to run a few of the test cases against this branch and see if anything else falls out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've done some light manual testing on this (rebased onto main). The only bug I found is also already on staging (for the curious -- on edit, the storage location defaults to the first storage location). I'm ok with it going into staging. @awwaiid ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@dorner: Your PR |
This PR does the following: