3986: Disallow duplicate items in audit

[dorner]

Resolves #3986.

Description

This change disallows audits from having multiple of the same item entered. This is almost certainly a mistake.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests.

[cielf]

It did stop me from saving a duplicate, but... I'm just getting a "Something didn't work quite right -- try again?" when entering a duplicate, and clicking either "Save Progress" or "Confirm Audit". We need to deliver the actual error to the user.

[dorner]

Just tried this myself on my local and I got the right error

Do you have more specific instructions to reproduce?

[dorner]

Saw an issue on update (not create) - fixed that.

[cielf]

@dorner Can we get rid of the "Base" easily? That's not something that's going to mean anything to our users.

[dorner]

It seems to be gone now. Not sure what caused it to show up.

[cielf]

Ok... that's weird, it is still happening on my local. (sigh)

[cielf]

@dorner It turns out that it's behaving differently on create and update. So it's showing the "Base" if you initially try to save with a duplicate, but not if you have saved an audit and then add a duplicate. One of them is calling "handle_audit_errors" and the other one is not.

[dorner]

@cielf should be fixed!

[cielf]

@dorner It works - thank you! But rubocop is unhappy.

[dorner]

Not any more!

[cielf]

LGTM!

[github-actions]

@dorner: Your PR 3986: Disallow duplicate items in audit is part of today's Human Essentials production release: 2024.01.21.
Thank you very much for your contribution!