fix: accessibility for filter labels #4046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
requested changes
Jan 20, 2024
Before labels were using the wrong id parameter and were not correctly labeling select elements.
elasticspoon
force-pushed
the
fix-filter-labels
branch
from
d54f140 to
7457aa8
Compare
In the off chance that there are two filters with the same scope on a page they would both have the same id. This adds a unique uuid value to the filters.
Previously systems tests would select filters by the id attribute, since ids are now followed by a uuid this is not possible. All the selections are now made using the name attribute.
dorner
requested changes
Jan 26, 2024
| <%= label_tag "by Source" %> | ||
| <%= select_tag "filters[by_source]", options_for_select(@sources, @selected_source), {include_blank: true, class: "form-control"} %> | ||
| <% id = "filter_#{SecureRandom.uuid}" %> | ||
| <%= label_tag id, "Filter by Source" %> |
There was a problem hiding this comment.
I think this changes the visible text? Was that on purpose?
There was a problem hiding this comment.
Yea. I thought it would make sense to make the labels consistent.
instead of
I guess by that logic I should also change date range, but it wasn't using any of the same helpers so I didn't touch anything around there.
dorner
approved these changes
Jan 29, 2024
|
Looks good, thanks! |
|
@awwaiid Please note this for the dashboard? Thanks. (Edit. Never mind -- it doesn't apply after all.) |
|
@elasticspoon: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filters on various pages were not labeled correctly. Though they had labels
had the wrong
for=attributes making them not functional for screen readers.This is an accessibility concern. This PR fixes the helper function to have the
correct id.
Note: my linter did some stuff but I only touched
app/helpers/filter_helper.rband a label tag in the donations index.
Before per lighthouse:
label for=andselect id=do not match, thus labels do not provide a11y correct function.After:
Type of change
How Has This Been Tested?
It passed all tests but I did not write any specifically for it.