Adds erb lint to project #4059
Merged
Adds erb lint to project #4059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds erb-lint to lint views to bundle. Adds rake task to do both erb and rubocop linting. Adds a settings file for erb lint
elasticspoon
force-pushed
the
adds-erb-lint-to-project
branch
from
51e8d33 to
b4a690b
Compare
linter no longer tries to lint vendor/bundle linter now also linted *.js.erb files linted *.js.erb files changes lint command suggestion in docs
elasticspoon
force-pushed
the
adds-erb-lint-to-project
branch
from
c1287af to
281a5f2
Compare
dorner
approved these changes
Feb 7, 2024
|
Thanks so much for the addition! |
|
@elasticspoon: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds erb-lint to the project. I also created a bin file to run both rubocop and erb-lint on the whole code base.
I ran the linter on the code base as discussed here
Potentially the rules in
erb-lint.ymlcould be changed. In theory it should be able to run rubocop on the contents for erb tags, however, that was not working for me.Tests
I did not add tests but the code still passes the full suite.