Add new column use_single_step_invite_and_approve_partner_process #4071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+1
to
+15
| # == Schema Information | ||
| # | ||
| # Table name: events | ||
| # | ||
| # id :bigint not null, primary key | ||
| # data :jsonb | ||
| # event_time :datetime not null | ||
| # eventable_type :string | ||
| # type :string not null | ||
| # created_at :datetime not null | ||
| # updated_at :datetime not null | ||
| # eventable_id :bigint | ||
| # organization_id :bigint | ||
| # user_id :bigint | ||
| # |
There was a problem hiding this comment.
The app added this by itself. Doesn't detract and adds some visibility. Figured I keep it.
|
Is this PR ready for review? It doesn't seem to be complete. If not, please mark it as "draft". |
@dorner Nope. sorry intention was to make it draft. Thanks! |
vincent-truong-main
changed the title
vincent-truong-main
force-pushed
the
3432-allow-banks-skip-partner-approval-process-opt-in-basis
branch
2 times, most recently
from
b7acc4b
to
6766cd1
Compare
| class AddUseSingleStepInviteAndApprovePartnerProcessToOrganization < ActiveRecord::Migration[7.0] | ||
| def change | ||
| add_column :organizations, :use_single_step_invite_and_approve_partner_process, :boolean | ||
| change_column_default :organizations, :use_single_step_invite_and_approve_partner_process, false |
There was a problem hiding this comment.
Will be adding a rake task to update the current records to have default false and also a not null constraint.
There was a problem hiding this comment.
You should be able to do that within the migration.
vincent-truong-main
force-pushed
the
3432-allow-banks-skip-partner-approval-process-opt-in-basis
branch
from
6766cd1
to
a0ee7ab
Compare
vincent-truong-main
changed the title
|
Folding this into #4075 |
vincent-truong-main
deleted the
3432-allow-banks-skip-partner-approval-process-opt-in-basis
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3432
Part 1 of 4 PRs for this issue.
Description
In order to allow banks to invite and approve partner as a single step when additional info isn't needed, a column,
use_single_step_invite_and_approve_partner_processis added in this PR.Type of change
How Has This Been Tested?
Screenshots