Fix one step invite migration to run in one line adding default false and not null instead of two #4091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+5
to
+15
| # id :integer not null, primary key | ||
| # city :string | ||
| # deadline_day :integer | ||
| # default_storage_location :integer | ||
| # distribute_monthly :boolean default(FALSE), not null | ||
| # email :string | ||
| # enable_child_based_requests :boolean default(TRUE), not null | ||
| # enable_individual_requests :boolean default(TRUE), not null | ||
| # enable_quantity_based_requests :boolean default(TRUE), not null | ||
| # intake_location :integer | ||
| # invitation_text :text |
There was a problem hiding this comment.
Some automatic reorganization
vincent-truong-main
force-pushed
the
fix-one-step-invite-migration
branch
from
0cd1ee4
to
e959bb1
Compare
dorner
approved these changes
Feb 8, 2024
|
Thanks for the fix! |
|
@vincent-truong-dev: Your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed with Hide Whitespace on
Description
While running the migration from #4075, we encountered an issue where null values where detected. This is because the column was added in two lines, first default then setting not null. This allowed some null values to slip in.
This PR changes migration to run one on line adding both default and non null inside safety assured block.
Type of change
How Has This Been Tested?
Ran migrations locally with no error.
Screenshots