Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding Design for Importing Partners #416

Merged
merged 4 commits into from
Jun 10, 2018
Merged

Conversation

melaniew
Copy link
Collaborator

Resolves #1

Description

• The "Import Partners" button currently links to a modal with detailed download & upload instructions. To improve the user experience, the instructions have been divided into two major steps and the design now includes font awesome icons, a modern font, and a clean, padded look. These design changes only effect the modal structure and style on the app/views/partners/index.html.erb file. Application.scss currently holds the updates modal's styles. This was requested during Ruby for Good 2018.

Type of change

• Design change

How Has This Been Tested?

• This has been tested in Chrome, Firefox, and Safari. IE has NOT been tested but the HTML and CSS changes shouldn't present a problem in IE11 or IEedge. The responsive flow is perfect.
onboarding-partners_after
onboarding-partners_before

Screenshots

• Before and After screenshots are attached.

@melaniew melaniew requested a review from armahillo June 10, 2018 02:03
@armahillo armahillo merged commit 46fb11e into master Jun 10, 2018
@armahillo
Copy link
Collaborator

Thanks @melaniew ! 💯 💯

@armahillo armahillo deleted the onboarding_partners branch June 10, 2018 14:07
@armahillo armahillo added Repo First-timer This Pull Request is a user's first contribution to Diaperbase Ruby for Good This Pull Request was created at a Ruby for Good event labels May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Repo First-timer This Pull Request is a user's first contribution to Diaperbase Ruby for Good This Pull Request was created at a Ruby for Good event
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants