Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Capybara Screenshoots not Uploading in CI #4191

Closed

Conversation

elasticspoon
Copy link
Collaborator

@elasticspoon elasticspoon commented Mar 12, 2024

Capybara screenshots are not uploading in CI.

This is because the path was incorrect it was looking for files in tmp/capybara but they were getting saved to tmp/screenshots. This fixes the issue.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Tests

Sample failed job with artifacts. https://github.com/rubyforgood/human-essentials/actions/runs/8256286176

@elasticspoon elasticspoon changed the title wip fix: Capybara Screenshoots not Uploading in CI Mar 12, 2024
Capybara screenshoots are not uploading in CI.

This is because the path was incorrect it was looking
for files in `tmp/capybara` but
they were getting saved to `tmp/screenshots`.
@elasticspoon elasticspoon marked this pull request as ready for review March 12, 2024 22:12
@elasticspoon
Copy link
Collaborator Author

Actually only 1 workflow that had the issue. I am just adding this to the action update PR #4196.

@elasticspoon elasticspoon deleted the fix-action-upload branch April 13, 2024 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant