Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#4065): make low_prio queue for caching #4200

Merged
merged 3 commits into from
Mar 26, 2024
Merged

fix(#4065): make low_prio queue for caching #4200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bdb1414
fix(#4065): make low_prio queue for caching
elasticspoon Mar 17, 2024
0d3aa31
fix: remove ?!?!?!?!?
elasticspoon Mar 18, 2024
bc6ddf5
Merge branch 'main' into 4065-add-queues
awwaiid Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/jobs/historical_data_cache_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,6 @@ def perform(org_id:, type:)

Rails.cache.write("#{organization.short_name}-historical-#{type}-data", HistoricalTrendService.new(organization.id, type).series)
end

def queue_name = "low_priority"
end
8 changes: 7 additions & 1 deletion config/initializers/delayed_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,13 @@
Delayed::Worker.max_attempts = 3
Delayed::Worker.max_run_time = 20.minutes
Delayed::Worker.read_ahead = 10
Delayed::Worker.default_queue_name = 'default'
Delayed::Worker.delay_jobs = !Rails.env.test?
Delayed::Worker.raise_signal_exceptions = :term
Delayed::Worker.logger = ActiveSupport::Logger.new(STDOUT)

# https://github.com/rubyforgood/human-essentials/issues/4065
Delayed::Worker.default_queue_name = 'default'
Delayed::Worker.queue_attributes = {
# bigger number is lower priority
"low_priority" => { priority: 10 }
}
2 changes: 1 addition & 1 deletion spec/jobs/historical_data_cache_job_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
it "queues the job" do
expect { job }.to have_enqueued_job(described_class)
.with(org_id: organization.id, type: type)
.on_queue("default")
.on_queue("low_priority")
end

it "caches the historical data" do
Expand Down