-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3067: add required info on csv partner export (partial solution) #4229
Merged
cielf
merged 7 commits into
rubyforgood:main
from
callmarx:3067-add-fields-to-partner-agency-export
Jun 9, 2024
Merged
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e850dd8
feat(3067): add required info on csv partner export
callmarx a1cdf3c
Merge branch 'main' into 3067-add-fields-to-partner-agency-export
callmarx 41681ee
fix(#3067): minor functionality quibbles
callmarx b38beca
fix(3067): includes other_agency_type info
callmarx 2e483ab
fix(#3067): minor quibbles and test the the exact array of csv_export…
callmarx f1a9fc3
Merge branch 'main' into 3067-add-fields-to-partner-agency-export
callmarx cb16dde
Merge branch 'main' into 3067-add-fields-to-partner-agency-export
callmarx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -291,21 +291,39 @@ | |
let(:contact_name) { "Jon Ralfeo" } | ||
let(:contact_email) { "jon@entertainment720.com" } | ||
let(:contact_phone) { "1231231234" } | ||
let(:agency_address) { "4744 McDermott Mountain" } | ||
let(:agency_city) { "Lake Shoshana" } | ||
let(:agency_state) { "ND" } | ||
let(:agency_zipcode) { "09980-7010" } | ||
let(:agency_website) { "bosco.example" } | ||
let(:agency_type) { "HEALTH" } | ||
let(:notes) { "Some notes" } | ||
|
||
before do | ||
partner.profile.update({ | ||
primary_contact_name: contact_name, | ||
primary_contact_email: contact_email, | ||
primary_contact_phone: contact_phone | ||
primary_contact_phone: contact_phone, | ||
address1: agency_address, | ||
city: agency_city, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would do a test with both address1 and address 2. |
||
state: agency_state, | ||
zip_code: agency_zipcode, | ||
website: agency_website, | ||
agency_type: agency_type, | ||
}) | ||
partner.update(notes: notes) | ||
end | ||
|
||
it "includes contact person information from parnerbase" do | ||
it "includes contact person and agency information from parnerbase" do | ||
expect(partner.csv_export_attributes).to include(contact_name) | ||
expect(partner.csv_export_attributes).to include(contact_phone) | ||
expect(partner.csv_export_attributes).to include(contact_email) | ||
expect(partner.csv_export_attributes).to include(agency_address) | ||
expect(partner.csv_export_attributes).to include(agency_city) | ||
expect(partner.csv_export_attributes).to include(agency_state) | ||
expect(partner.csv_export_attributes).to include(agency_zipcode) | ||
expect(partner.csv_export_attributes).to include(agency_website) | ||
expect(partner.csv_export_attributes).to include(agency_type) | ||
expect(partner.csv_export_attributes).to include(notes) | ||
end | ||
dorner marked this conversation as resolved.
Show resolved
Hide resolved
|
||
end | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor quibble: inconsistent capitalization -- please caplitalize address.